generator: sync erb template to use Rails 7.0 APIs #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhh Are you comfortable with dropping Rails 6.1 feature support in a minor release (likely v2.7.0) if/when this gets merged? |
This updates the erb template to be in sync with the template in rails/rails
We will still provide security support for the previous minor release while Rails 6.1 is supported.
flavorjones
force-pushed
the
update-templates-to-rails-7.0
branch
from
70bb6b4
to
3bf5cb9
Compare
|
Rafael says he doesn't have concerns: https://discord.com/channels/849034466856665118/974005005768069211/1235247109012197517 But I'll give folks a chance to object before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is derived from the work @kinsomicrote did in #357.
Updates the erb templates to be in sync with the templates in rails/rails 7.0+ and so correctly supports namespaced models (see related rails/rails#43611).