Convert to ESM #1391

wmertens · 2024-04-01T16:25:22Z

No description provided.

wmertens · 2024-04-01T16:29:37Z

The failing test is trying to import the esm module as cjs which should't work.

raineorshine · 2024-04-01T17:19:17Z

The CJS test can be removed since it will no longer be supported.

wmertens · 2024-04-04T10:45:57Z

All good now 😃

raineorshine · 2024-04-04T12:15:09Z

test/e2e.sh

+  # turn off stop on error
+  set +e


Can you clarify why this is needed?

IIRC this was causing the verdaccio shutdown to fail. Not sure any more :-/

raineorshine · 2024-04-04T12:17:18Z

test/e2e.sh

-
+  # turn off stop on error
+  set +e
+
  exit_status=$?


This needs to be the first line in the trap function to capture the exit code correctly. I'm seeing "Done" printed instead of "Error" when I fail the test intentionally.

raineorshine · 2024-04-04T12:35:13Z

package.json

    "lint:src": "eslint --cache --cache-location node_modules/.cache/.eslintcache --ignore-path .gitignore --report-unused-disable-directives .",
    "prepare": "src/scripts/install-hooks && test/bun-setup.sh",
    "prepublishOnly": "npm run build",
    "prettier": "prettier . --check",
    "test": "npm run test:unit && npm run test:e2e",
-    "test:unit": "mocha test test/package-managers/*",
+    "test:unit": "vitest test/package-managers/*",


You've accidentally dropped the main test suite in the test directory. Once enabled, I'm seeing: process.chdir() is not supported in workers.

how did I drop it? Not sure why that message though.

mocha test test/package-managers/* specifies two paths: ./test and ./test/package-managers/*. This edit removes the ./test path from the test:unit script (which is the main test suite for the project).

ah maybe because it always used chdir and vitest uses workers?

process.chdir is only used in getAllPackages.test.ts, and it appears to be a remnant of some local testing that another developer did. The tests pass without it, so I removed it in 688c07f.

You can either rebase on main, or cherry pick that commit if you want to get the tests working before dealing with the merge conflicts.

raineorshine · 2024-04-25T15:37:05Z

@wmertens Just checking in to see if you have an update.

wmertens · 2024-04-25T16:24:08Z

I'm trying to rebase but

npm ERR! command bash -c node install.js
npm ERR! Failed to find package "@oven/bun-linux-x64". You may have used the "--no-optional" flag when running "npm install".
npm ERR! Failed to find package "@oven/bun-linux-x64-baseline". You may have used the "--no-optional" flag when running "npm install".

raineorshine · 2024-04-25T18:20:43Z

Sorry about that! I got the same thing, but I was hoping it would work once the lock file was updated. It installs fine in ci mode.

Try npm install -f bun. That worked for me. I'll circle back with a better fix soon.

wmertens · 2024-04-25T20:52:04Z

:( doesn't work, and when I try to install oven, it gets worse:

1223 $ npm i -f bun @oven/bun-linux-x64 @oven/bun-linux-x64-baseline
npm WARN using --force Recommended protections disabled.
npm ERR! code 1
npm ERR! path /home/wmertens/Projects/npm-check-updates/node_modules/bun
npm ERR! command failed
npm ERR! command bash -c node install.js
npm ERR! Failed to find package "@oven/bun-linux-x64". You may have used the "--no-optional" flag when running "npm install".
npm ERR! Failed to install package "@oven/bun-linux-x64" using "npm install". Error: ENOENT: no such file or directory, rename '/tmp/bun-IZCrJ9/node_modules/@oven/bun-linux-x64' -> 'node_modules/@oven/bun-linux-x64'
npm ERR!     at Object.renameSync (node:fs:1032:11)
npm ERR!     at rename (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:202:21)
npm ERR!     at installBun (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:388:23)
npm ERR!     at /home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:360:7
npm ERR!     at Generator.next (<anonymous>)
npm ERR!     at /home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:41:59
npm ERR!     at new Promise (<anonymous>)
npm ERR!     at __async (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:27:51)
npm ERR!     at requireBun (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:341:10)
npm ERR!     at /home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:332:22 {
npm ERR!   errno: -2,
npm ERR!   code: 'ENOENT',
npm ERR!   syscall: 'rename',
npm ERR!   path: '/tmp/bun-IZCrJ9/node_modules/@oven/bun-linux-x64',
npm ERR!   dest: 'node_modules/@oven/bun-linux-x64'
npm ERR! }
npm ERR! Failed to find package "@oven/bun-linux-x64-baseline". You may have used the "--no-optional" flag when running "npm install".
npm ERR! Failed to install package "@oven/bun-linux-x64-baseline" using "npm install". Error: EXDEV: cross-device link not permitted, rename '/tmp/bun-4Pgjla/node_modules/@oven/bun-linux-x64-baseline' -> 'node_modules/@oven/bun-linux-x64-baseline'
npm ERR!     at Object.renameSync (node:fs:1032:11)
npm ERR!     at rename (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:202:21)
npm ERR!     at installBun (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:388:23)
npm ERR!     at /home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:360:7
npm ERR!     at Generator.next (<anonymous>)
npm ERR!     at /home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:41:59
npm ERR!     at new Promise (<anonymous>)
npm ERR!     at __async (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:27:51)
npm ERR!     at requireBun (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:341:10)
npm ERR!     at /home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:332:22 {
npm ERR!   errno: -18,
npm ERR!   code: 'EXDEV',
npm ERR!   syscall: 'rename',
npm ERR!   path: '/tmp/bun-4Pgjla/node_modules/@oven/bun-linux-x64-baseline',
npm ERR!   dest: 'node_modules/@oven/bun-linux-x64-baseline'
npm ERR! }
npm ERR! Error: Failed to install package "bun"
npm ERR!     at /home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:336:11
npm ERR!     at Generator.throw (<anonymous>)
npm ERR!     at rejected (/home/wmertens/Projects/npm-check-updates/node_modules/bun/install.js:36:27)
npm ERR!     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

npm ERR! A complete log of this run can be found in: /home/wmertens/.npm/_logs/2024-04-25T20_49_55_667Z-debug-0.log

wmertens · 2024-04-25T20:59:40Z

I tried pushing without updating the npm lock but then the markdown lint complains about readme

raineorshine · 2024-04-25T22:50:32Z

Okay. I think since bun is not very cross-platform compatible, I will move it into a separate optional test script, and remove it from devDependencies.

raineorshine · 2024-04-26T01:27:31Z

Okay, I've offloaded the bun tests to a separate script in bc18c92. You no longer need bun to npm install and run the unit tests.

uses same build setup as vite; mocha doesn't like ESM

wmertens force-pushed the esm branch 3 times, most recently from 98b1244 to 74b5c39 Compare April 4, 2024 06:37

raineorshine requested changes Apr 4, 2024

View reviewed changes

wmertens force-pushed the esm branch 2 times, most recently from 48bba1e to 16d9f6f Compare April 25, 2024 16:16

raineorshine force-pushed the main branch 3 times, most recently from 26c7b5c to bc18c92 Compare April 26, 2024 01:22

wmertens added 2 commits April 26, 2024 21:44

convert to esm

f8e30f2

use vitest instead of mocha

e04348d

uses same build setup as vite; mocha doesn't like ESM

wmertens force-pushed the esm branch from 16d9f6f to e04348d Compare April 26, 2024 20:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert to ESM #1391

Convert to ESM #1391

wmertens commented Apr 1, 2024

wmertens commented Apr 1, 2024

raineorshine commented Apr 1, 2024

wmertens commented Apr 4, 2024

raineorshine Apr 4, 2024

wmertens Apr 25, 2024

raineorshine Apr 4, 2024

raineorshine Apr 4, 2024 •

edited

wmertens Apr 25, 2024

raineorshine Apr 25, 2024

wmertens Apr 25, 2024

raineorshine Apr 25, 2024 •

edited

raineorshine commented Apr 25, 2024

wmertens commented Apr 25, 2024

raineorshine commented Apr 25, 2024

wmertens commented Apr 25, 2024

wmertens commented Apr 25, 2024

raineorshine commented Apr 25, 2024

raineorshine commented Apr 26, 2024 •

edited

Convert to ESM #1391

Are you sure you want to change the base?

Convert to ESM #1391

Conversation

wmertens commented Apr 1, 2024

wmertens commented Apr 1, 2024

raineorshine commented Apr 1, 2024

wmertens commented Apr 4, 2024

raineorshine Apr 4, 2024

Choose a reason for hiding this comment

wmertens Apr 25, 2024

Choose a reason for hiding this comment

raineorshine Apr 4, 2024

Choose a reason for hiding this comment

raineorshine Apr 4, 2024 • edited

Choose a reason for hiding this comment

wmertens Apr 25, 2024

Choose a reason for hiding this comment

raineorshine Apr 25, 2024

Choose a reason for hiding this comment

wmertens Apr 25, 2024

Choose a reason for hiding this comment

raineorshine Apr 25, 2024 • edited

Choose a reason for hiding this comment

raineorshine commented Apr 25, 2024

wmertens commented Apr 25, 2024

raineorshine commented Apr 25, 2024

wmertens commented Apr 25, 2024

wmertens commented Apr 25, 2024

raineorshine commented Apr 25, 2024

raineorshine commented Apr 26, 2024 • edited

raineorshine Apr 4, 2024 •

edited

raineorshine Apr 25, 2024 •

edited

raineorshine commented Apr 26, 2024 •

edited