Reduce the installation size even more #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed, converting the PR to draft for now. |
SukkaW
force-pushed
the
reduce-bundle-size-2
branch
2 times, most recently
from
c7d1953
to
a84b16b
Compare
SukkaW
force-pushed
the
reduce-bundle-size-2
branch
from
a84b16b
to
1320ee0
Compare
|
@raineorshine Now CI has passed, the PR is ready for review. |
raineorshine
approved these changes
Apr 10, 2024
Comment on lines
-539
to
+537
| /** Reverts a valid semver version to a pseudo version. NOOP If the original version was a valid semver version. */ | ||
| const revertPseudoVersion = (current: string, latest: string) => | ||
| flow(revertLeadingV(current), revertMissingMinorAndPatch(current), revertMissingPatch(current))(latest) | ||
| return result | ||
| } |
There was a problem hiding this comment.
I'll accept this change, though a slightly preferable approach would have been to implement a simple flow function and preserve the existing structure of the code. (The currying was clearly unnecessary though.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR follows #1394.
The PR reduces another 100 KiB from the installation size: