Respect preserveComments option in tempate.ast() (babel#11112)

rajasekarm · Feb 17, 2020 · d778427 · d778427
1 parent 87d20e3
commit d778427
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/babel-template/src/options.js b/packages/babel-template/src/options.js
@@ -131,7 +131,7 @@ export function validate(opts: mixed): TemplateOpts {
     placeholderWhitelist: placeholderWhitelist || undefined,
     placeholderPattern:
       placeholderPattern == null ? undefined : placeholderPattern,
-    preserveComments: preserveComments == null ? false : preserveComments,
+    preserveComments: preserveComments == null ? undefined : preserveComments,
     syntacticPlaceholders:
       syntacticPlaceholders == null ? undefined : syntacticPlaceholders,
   };

diff --git a/packages/babel-template/test/index.js b/packages/babel-template/test/index.js
@@ -28,6 +28,18 @@ describe("@babel/template", function() {
     expect(generator(output).code).toBe(comments);
   });
 
+  it("should preserve comments with a flag", function() {
+    const output = template(comments, { preserveComments: true })();
+    expect(generator(output).code).toBe(comments);
+  });
+
+  it("should preserve comments with a flag when using .ast", function() {
+    const output1 = template.ast(comments, { preserveComments: true });
+    const output2 = template({ preserveComments: true }).ast(comments);
+    expect(generator(output1).code).toBe(comments);
+    expect(generator(output2).code).toBe(comments);
+  });
+
   describe("string-based", () => {
     it("should handle replacing values from an object", () => {
       const value = t.stringLiteral("some string value");