Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added addIndexRight #2140

Merged
merged 1 commit into from Feb 5, 2022
Merged

Conversation

briancaine
Copy link
Contributor

Implemented addIndexRight from #1898.

@briancaine briancaine force-pushed the feature/addIndexRight branch 3 times, most recently from e2a07bb to 21e34f5 Compare March 22, 2017 23:46
@CrossEye
Copy link
Member

LGTM

CrossEye
CrossEye previously approved these changes Jan 22, 2022
@CrossEye
Copy link
Member

@briancaine: as with many issues around this time, this PR was totally dropped. Sorry about that. We're getting around to addressing all these old issues, and just came across this one.

If you're interested in pursuing it, could you fix the conflict in index.js? If not, feel free to close it.

@customcommander
Copy link
Member

@CrossEye Rebased against master and fixed the conflicts. Will fail until #3224 is merged.

@customcommander
Copy link
Member

@CrossEye Merge conflicts, lint and tests errors fixed. Good to go.

@CrossEye CrossEye self-assigned this Jan 27, 2022
Copy link
Member

@CrossEye CrossEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

🌿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants