Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't dispatch transformers to 'fantasy-land/reduce' #2767

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't dispatch transformers to 'fantasy-land/reduce' #2767

wants to merge 2 commits into from

Conversation

wojpawlik
Copy link
Contributor

_reduce no longer tries to dispatch transformers to fantasy-land/reduce, because reduced support is forbidden by the spec:

iii. f must return a value of the same type as x.
iv. No parts of f's return value should be checked.


Extracted from #2762, discussing it over there could be messy.

This solution avoids unnecessary _xwrap. An alternative solution avoids nesting.

@CrossEye
Copy link
Member

🌿

I can't see a reason not to do this, and it's certainly a simpler fix than the alternative. Any other thoughts, @ramda/core ?

@CrossEye CrossEye added the resolve-conflicts PR needs to be updated due to conflicts before merging label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolve-conflicts PR needs to be updated due to conflicts before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants