Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code climate fix #3431

Merged
merged 12 commits into from
Dec 4, 2023
Merged

code climate fix #3431

merged 12 commits into from
Dec 4, 2023

Conversation

kedashoe
Copy link
Contributor

@kedashoe kedashoe commented Nov 19, 2023

This PR updates git actions to no longer use code climate. It hasn't been working for over a year at least in any event. For various pull request related actions (open, request review, etc), coverage will run and a comment will be created/updated on the PR.

@kedashoe
Copy link
Contributor Author

@hitmands , looks like you helped out with the original PR adding code climate to ramda: #3033

Do you have any thoughts on why it is currently failing?

The current error on master

/home/runner/work/_actions/paambaati/codeclimate-action/v2.6.0/node_modules/@actions/core/lib/command.js:66
        .replace(/%/g, '%25')
         ^

TypeError: (s || "").replace is not a function

I've updated some dependencies in this PR, and am getting

Error: you must supply a CC_TEST_REPORTER_ID ENV variable or pass it via the -r flag

I see code climate also has a github app? https://docs.codeclimate.com/docs/open-source-free. Maybe we can use that directly?

@hitmands
Copy link
Member

I see code climate also has a github app? https://docs.codeclimate.com/docs/open-source-free. Maybe we can use that directly?

Then put lcov processing back, as it seems like cc is processing json (by looking at the job logs)

coverageLocations: |
            ${{github.workspace}}/coverage/lcov.info:lcov

@kedashoe kedashoe merged commit 74cfca7 into ramda:master Dec 4, 2023
4 checks passed
@kedashoe kedashoe deleted the code-climate-fix branch December 4, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants