replaced let with var in _clone.js for consistency #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Results> ramda@0.29.1 coverage
> BABEL_ENV=cjs nyc --reporter=text-summary --reporter=text mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1188 passing (926ms)
=============================== Coverage summary ===============================
Statements : 94.03% ( 2473/2630 )
Branches : 85.76% ( 970/1131 )
Functions : 93.24% ( 552/592 )
Lines : 94.31% ( 2319/2459 )
================================================================================
------------------------------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------------------|---------|----------|---------|---------|-------------------
All files | 94.03 | 85.76 | 93.24 | 94.31 |
scripts/transpile | 94.2 | 84.62 | 100 | 94.2 |
esm-to-cjs.js | 92.11 | 75 | 100 | 92.11 | 92,97,119
wrap-constructor-pattern.js | 96.77 | 92.86 | 100 | 96.77 | 73
source | 97.03 | 91.28 | 97.61 | 97.14 |
F.js | 100 | 100 | 100 | 100 |
T.js | 100 | 100 | 100 | 100 |
__.js | 100 | 100 | 100 | 100 |
add.js | 100 | 100 | 100 | 100 |
addIndex.js | 100 | 100 | 100 | 100 |
addIndexRight.js | 100 | 100 | 100 | 100 |
adjust.js | 100 | 100 | 100 | 100 |
all.js | 100 | 100 | 100 | 100 |
allPass.js | 100 | 100 | 100 | 100 |
always.js | 100 | 100 | 100 | 100 |
and.js | 100 | 100 | 100 | 100 |
andThen.js | 100 | 100 | 100 | 100 |
any.js | 100 | 100 | 100 | 100 |
anyPass.js | 100 | 100 | 100 | 100 |
ap.js | 100 | 100 | 100 | 100 |
aperture.js | 100 | 100 | 100 | 100 |
append.js | 100 | 100 | 100 | 100 |
apply.js | 100 | 100 | 100 | 100 |
applySpec.js | 100 | 100 | 100 | 100 |
applyTo.js | 100 | 100 | 100 | 100 |
ascend.js | 100 | 100 | 100 | 100 |
assoc.js | 100 | 100 | 100 | 100 |
assocPath.js | 100 | 100 | 100 | 100 |
binary.js | 100 | 100 | 100 | 100 |
bind.js | 100 | 100 | 100 | 100 |
both.js | 100 | 100 | 100 | 100 |
call.js | 100 | 100 | 100 | 100 |
chain.js | 100 | 100 | 100 | 100 |
clamp.js | 80 | 83.33 | 100 | 80 | 25
clone.js | 100 | 100 | 100 | 100 |
collectBy.js | 100 | 100 | 100 | 100 |
comparator.js | 100 | 100 | 100 | 100 |
complement.js | 100 | 100 | 100 | 100 |
compose.js | 100 | 100 | 100 | 100 |
composeWith.js | 100 | 100 | 100 | 100 |
concat.js | 86.67 | 87.5 | 100 | 86.67 | 47,50
cond.js | 100 | 100 | 100 | 100 |
construct.js | 100 | 100 | 100 | 100 |
constructN.js | 68.42 | 57.14 | 100 | 66.67 | 53-55,57-59
converge.js | 100 | 100 | 100 | 100 |
count.js | 100 | 100 | 100 | 100 |
countBy.js | 100 | 100 | 100 | 100 |
curry.js | 100 | 100 | 100 | 100 |
curryN.js | 100 | 100 | 100 | 100 |
dec.js | 100 | 100 | 100 | 100 |
defaultTo.js | 100 | 100 | 100 | 100 |
descend.js | 100 | 100 | 100 | 100 |
difference.js | 100 | 100 | 100 | 100 |
differenceWith.js | 100 | 100 | 100 | 100 |
dissoc.js | 100 | 100 | 100 | 100 |
dissocPath.js | 88.89 | 72.73 | 100 | 88.89 | 19,50
divide.js | 100 | 100 | 100 | 100 |
drop.js | 100 | 100 | 100 | 100 |
dropLast.js | 100 | 100 | 100 | 100 |
dropLastWhile.js | 100 | 100 | 100 | 100 |
dropRepeats.js | 100 | 100 | 100 | 100 |
dropRepeatsBy.js | 100 | 100 | 100 | 100 |
dropRepeatsWith.js | 100 | 100 | 100 | 100 |
dropWhile.js | 100 | 100 | 100 | 100 |
either.js | 100 | 100 | 100 | 100 |
empty.js | 100 | 92.86 | 100 | 100 | 37,39
endsWith.js | 100 | 100 | 100 | 100 |
eqBy.js | 100 | 100 | 100 | 100 |
eqProps.js | 100 | 100 | 100 | 100 |
equals.js | 100 | 100 | 100 | 100 |
evolve.js | 100 | 100 | 100 | 100 |
filter.js | 100 | 100 | 100 | 100 |
find.js | 100 | 100 | 100 | 100 |
findIndex.js | 100 | 100 | 100 | 100 |
findLast.js | 100 | 100 | 100 | 100 |
findLastIndex.js | 100 | 100 | 100 | 100 |
flatten.js | 100 | 100 | 100 | 100 |
flip.js | 100 | 100 | 100 | 100 |
forEach.js | 100 | 100 | 100 | 100 |
forEachObjIndexed.js | 100 | 100 | 100 | 100 |
fromPairs.js | 100 | 100 | 100 | 100 |
groupBy.js | 100 | 100 | 100 | 100 |
groupWith.js | 100 | 100 | 100 | 100 |
gt.js | 100 | 100 | 100 | 100 |
gte.js | 100 | 100 | 100 | 100 |
has.js | 100 | 100 | 100 | 100 |
hasIn.js | 100 | 100 | 100 | 100 |
hasPath.js | 100 | 100 | 100 | 100 |
head.js | 100 | 100 | 100 | 100 |
identical.js | 90 | 80 | 100 | 90 | 40
identity.js | 100 | 100 | 100 | 100 |
ifElse.js | 100 | 100 | 100 | 100 |
inc.js | 100 | 100 | 100 | 100 |
includes.js | 100 | 100 | 100 | 100 |
indexBy.js | 100 | 100 | 100 | 100 |
indexOf.js | 100 | 100 | 100 | 100 |
init.js | 100 | 100 | 100 | 100 |
innerJoin.js | 100 | 100 | 100 | 100 |
insert.js | 100 | 100 | 100 | 100 |
insertAll.js | 100 | 100 | 100 | 100 |
intersection.js | 100 | 100 | 100 | 100 |
intersperse.js | 100 | 100 | 100 | 100 |
into.js | 100 | 100 | 100 | 100 |
invert.js | 100 | 100 | 100 | 100 |
invertObj.js | 100 | 100 | 100 | 100 |
invoker.js | 100 | 100 | 100 | 100 |
is.js | 100 | 100 | 100 | 100 |
isEmpty.js | 100 | 100 | 100 | 100 |
isNil.js | 100 | 100 | 100 | 100 |
isNotEmpty.js | 100 | 100 | 100 | 100 |
isNotNil.js | 100 | 100 | 100 | 100 |
join.js | 100 | 100 | 100 | 100 |
juxt.js | 100 | 100 | 100 | 100 |
keys.js | 30 | 21.74 | 50 | 30 | 18-25,51-72
keysIn.js | 100 | 100 | 100 | 100 |
last.js | 100 | 100 | 100 | 100 |
lastIndexOf.js | 100 | 100 | 100 | 100 |
length.js | 100 | 100 | 100 | 100 |
lens.js | 100 | 100 | 100 | 100 |
lensIndex.js | 100 | 100 | 100 | 100 |
lensPath.js | 100 | 100 | 100 | 100 |
lensProp.js | 100 | 100 | 100 | 100 |
lift.js | 100 | 100 | 100 | 100 |
liftN.js | 100 | 100 | 100 | 100 |
lt.js | 100 | 100 | 100 | 100 |
lte.js | 100 | 100 | 100 | 100 |
map.js | 100 | 100 | 100 | 100 |
mapAccum.js | 100 | 100 | 100 | 100 |
mapAccumRight.js | 100 | 100 | 100 | 100 |
mapObjIndexed.js | 100 | 100 | 100 | 100 |
match.js | 100 | 100 | 100 | 100 |
mathMod.js | 100 | 100 | 100 | 100 |
max.js | 100 | 100 | 100 | 100 |
maxBy.js | 100 | 100 | 100 | 100 |
mean.js | 100 | 100 | 100 | 100 |
median.js | 100 | 83.33 | 100 | 100 | 30
memoizeWith.js | 100 | 100 | 100 | 100 |
mergeAll.js | 100 | 100 | 100 | 100 |
mergeDeepLeft.js | 100 | 100 | 100 | 100 |
mergeDeepRight.js | 100 | 100 | 100 | 100 |
mergeDeepWith.js | 100 | 100 | 100 | 100 |
mergeDeepWithKey.js | 100 | 100 | 100 | 100 |
mergeLeft.js | 100 | 100 | 100 | 100 |
mergeRight.js | 100 | 100 | 100 | 100 |
mergeWith.js | 100 | 100 | 100 | 100 |
mergeWithKey.js | 100 | 100 | 100 | 100 |
min.js | 100 | 100 | 100 | 100 |
minBy.js | 100 | 100 | 100 | 100 |
modify.js | 100 | 100 | 100 | 100 |
modifyPath.js | 100 | 100 | 100 | 100 |
modulo.js | 100 | 100 | 100 | 100 |
move.js | 100 | 100 | 100 | 100 |
multiply.js | 100 | 100 | 100 | 100 |
nAry.js | 65.38 | 66.67 | 58.33 | 73.33 | 40,42,44-45
negate.js | 100 | 100 | 100 | 100 |
none.js | 100 | 100 | 100 | 100 |
not.js | 100 | 100 | 100 | 100 |
nth.js | 100 | 100 | 100 | 100 |
nthArg.js | 100 | 100 | 100 | 100 |
o.js | 100 | 100 | 100 | 100 |
objOf.js | 100 | 100 | 100 | 100 |
of.js | 100 | 75 | 100 | 100 | 33
omit.js | 100 | 100 | 100 | 100 |
on.js | 100 | 100 | 100 | 100 |
once.js | 100 | 100 | 100 | 100 |
or.js | 100 | 100 | 100 | 100 |
otherwise.js | 100 | 100 | 100 | 100 |
over.js | 100 | 100 | 100 | 100 |
pair.js | 100 | 100 | 100 | 100 |
partial.js | 100 | 100 | 100 | 100 |
partialObject.js | 100 | 100 | 100 | 100 |
partialRight.js | 100 | 100 | 100 | 100 |
partition.js | 100 | 100 | 100 | 100 |
path.js | 100 | 100 | 100 | 100 |
pathEq.js | 100 | 100 | 100 | 100 |
pathOr.js | 100 | 100 | 100 | 100 |
pathSatisfies.js | 100 | 100 | 100 | 100 |
paths.js | 100 | 100 | 100 | 100 |
pick.js | 100 | 100 | 100 | 100 |
pickAll.js | 100 | 100 | 100 | 100 |
pickBy.js | 100 | 100 | 100 | 100 |
pipe.js | 100 | 100 | 100 | 100 |
pipeWith.js | 88.89 | 50 | 100 | 88.89 | 35
pluck.js | 100 | 100 | 100 | 100 |
prepend.js | 100 | 100 | 100 | 100 |
product.js | 100 | 100 | 100 | 100 |
project.js | 100 | 100 | 100 | 100 |
promap.js | 100 | 100 | 100 | 100 |
prop.js | 100 | 100 | 100 | 100 |
propEq.js | 100 | 100 | 100 | 100 |
propIs.js | 100 | 100 | 100 | 100 |
propOr.js | 100 | 100 | 100 | 100 |
propSatisfies.js | 100 | 100 | 100 | 100 |
props.js | 100 | 100 | 100 | 100 |
range.js | 100 | 87.5 | 100 | 100 | 26
reduce.js | 100 | 100 | 100 | 100 |
reduceBy.js | 100 | 100 | 100 | 100 |
reduceRight.js | 100 | 100 | 100 | 100 |
reduceWhile.js | 100 | 100 | 100 | 100 |
reduced.js | 100 | 100 | 100 | 100 |
reject.js | 100 | 100 | 100 | 100 |
remove.js | 100 | 100 | 100 | 100 |
repeat.js | 100 | 100 | 100 | 100 |
replace.js | 100 | 100 | 100 | 100 |
reverse.js | 100 | 100 | 100 | 100 |
scan.js | 100 | 100 | 100 | 100 |
sequence.js | 100 | 75 | 100 | 100 | 39,47
set.js | 100 | 100 | 100 | 100 |
slice.js | 100 | 100 | 100 | 100 |
sort.js | 100 | 100 | 100 | 100 |
sortBy.js | 100 | 75 | 100 | 100 | 41
sortWith.js | 100 | 100 | 100 | 100 |
split.js | 100 | 100 | 100 | 100 |
splitAt.js | 100 | 100 | 100 | 100 |
splitEvery.js | 100 | 100 | 100 | 100 |
splitWhen.js | 100 | 100 | 100 | 100 |
splitWhenever.js | 100 | 100 | 100 | 100 |
startsWith.js | 100 | 100 | 100 | 100 |
subtract.js | 100 | 100 | 100 | 100 |
sum.js | 100 | 100 | 100 | 100 |
swap.js | 100 | 95.83 | 100 | 100 | 47
symmetricDifference.js | 100 | 100 | 100 | 100 |
symmetricDifferenceWith.js | 100 | 100 | 100 | 100 |
tail.js | 100 | 100 | 100 | 100 |
take.js | 100 | 100 | 100 | 100 |
takeLast.js | 100 | 100 | 100 | 100 |
takeLastWhile.js | 100 | 100 | 100 | 100 |
takeWhile.js | 100 | 100 | 100 | 100 |
tap.js | 100 | 100 | 100 | 100 |
test.js | 100 | 100 | 100 | 100 |
thunkify.js | 100 | 100 | 100 | 100 |
times.js | 100 | 100 | 100 | 100 |
toLower.js | 100 | 100 | 100 | 100 |
toPairs.js | 100 | 100 | 100 | 100 |
toPairsIn.js | 100 | 100 | 100 | 100 |
toString.js | 100 | 100 | 100 | 100 |
toUpper.js | 100 | 100 | 100 | 100 |
transduce.js | 100 | 100 | 100 | 100 |
transpose.js | 100 | 100 | 100 | 100 |
traverse.js | 100 | 87.5 | 100 | 100 | 43
trim.js | 66.67 | 80 | 50 | 66.67 | 26-28
tryCatch.js | 100 | 100 | 100 | 100 |
type.js | 100 | 100 | 100 | 100 |
unapply.js | 100 | 100 | 100 | 100 |
unary.js | 100 | 100 | 100 | 100 |
uncurryN.js | 100 | 100 | 100 | 100 |
unfold.js | 100 | 100 | 100 | 100 |
union.js | 100 | 100 | 100 | 100 |
unionWith.js | 100 | 100 | 100 | 100 |
uniq.js | 100 | 100 | 100 | 100 |
uniqBy.js | 100 | 100 | 100 | 100 |
uniqWith.js | 100 | 100 | 100 | 100 |
unless.js | 100 | 100 | 100 | 100 |
unnest.js | 100 | 100 | 100 | 100 |
until.js | 100 | 100 | 100 | 100 |
unwind.js | 100 | 100 | 100 | 100 |
update.js | 100 | 100 | 100 | 100 |
useWith.js | 100 | 100 | 100 | 100 |
values.js | 100 | 100 | 100 | 100 |
valuesIn.js | 100 | 100 | 100 | 100 |
view.js | 100 | 100 | 100 | 100 |
when.js | 100 | 100 | 100 | 100 |
where.js | 100 | 100 | 100 | 100 |
whereAny.js | 100 | 100 | 100 | 100 |
whereEq.js | 100 | 100 | 100 | 100 |
without.js | 100 | 100 | 100 | 100 |
xor.js | 100 | 100 | 100 | 100 |
xprod.js | 100 | 100 | 100 | 100 |
zip.js | 100 | 100 | 100 | 100 |
zipObj.js | 100 | 100 | 100 | 100 |
zipWith.js | 100 | 100 | 100 | 100 |
source/internal | 89.43 | 80.57 | 86.83 | 90.06 |
_Set.js | 75 | 63.38 | 100 | 75 | 64-76,109-124
_aperture.js | 100 | 100 | 100 | 100 |
_arity.js | 64 | 58.33 | 66.67 | 64.29 | 10,12-15
_arrayFromIterator.js | 100 | 100 | 100 | 100 |
_arrayReduce.js | 100 | 100 | 100 | 100 |
_assertPromise.js | 100 | 100 | 100 | 100 |
_assoc.js | 100 | 100 | 100 | 100 |
_checkForMethod.js | 85.71 | 83.33 | 100 | 85.71 | 18
_clone.js | 84.21 | 84.62 | 100 | 88.46 | 111-118
_cloneRegExp.js | 100 | 57.14 | 100 | 100 | 2-7
_complement.js | 100 | 100 | 100 | 100 |
_concat.js | 100 | 75 | 100 | 100 | 13
_createPartialApplicator.js | 100 | 100 | 100 | 100 |
_createReduce.js | 81.25 | 71.43 | 100 | 81.25 | 15,21,27
_curry1.js | 100 | 100 | 100 | 100 |
_curry2.js | 88.89 | 84.62 | 80 | 88.89 | 28
_curry3.js | 52.94 | 56.76 | 33.33 | 52.94 | 27-29,35-45
_curryN.js | 100 | 100 | 100 | 100 |
_dispatchable.js | 93.33 | 87.5 | 100 | 93.33 | 23
_dissoc.js | 90 | 83.33 | 100 | 90 | 15
_dropLast.js | 100 | 100 | 100 | 100 |
_dropLastWhile.js | 100 | 100 | 100 | 100 |
_equals.js | 98.18 | 98.8 | 100 | 98.18 | 61
_filter.js | 100 | 100 | 100 | 100 |
_flatCat.js | 100 | 50 | 100 | 100 | 17-26
_forceReduced.js | 50 | 100 | 0 | 50 | 2
_functionName.js | 100 | 50 | 100 | 100 | 4
_has.js | 100 | 100 | 100 | 100 |
_identity.js | 100 | 100 | 100 | 100 |
_includes.js | 100 | 100 | 100 | 100 |
_includesWith.js | 100 | 100 | 100 | 100 |
_indexOf.js | 96.3 | 91.67 | 100 | 96.3 | 16
_isArguments.js | 83.33 | 50 | 66.67 | 83.33 | 8
_isArray.js | 50 | 20 | 0 | 50 | 14
_isArrayLike.js | 86.67 | 85.71 | 100 | 100 | 28-29
_isFunction.js | 100 | 100 | 100 | 100 |
_isInteger.js | 50 | 50 | 0 | 50 | 10
_isNumber.js | 100 | 100 | 100 | 100 |
_isObject.js | 100 | 100 | 100 | 100 |
_isPlaceholder.js | 100 | 100 | 100 | 100 |
_isRegExp.js | 100 | 100 | 100 | 100 |
_isString.js | 100 | 100 | 100 | 100 |
_isTransformer.js | 100 | 100 | 100 | 100 |
_isTypedArray.js | 100 | 100 | 100 | 100 |
_makeFlat.js | 100 | 100 | 100 | 100 |
_map.js | 100 | 100 | 100 | 100 |
_modify.js | 100 | 100 | 100 | 100 |
_nth.js | 100 | 100 | 100 | 100 |
_objectAssign.js | 13.33 | 12.5 | 0 | 13.33 | 5-23
_objectIs.js | 25 | 12.5 | 0 | 25 | 4-9
_path.js | 100 | 100 | 100 | 100 |
_pipe.js | 100 | 100 | 100 | 100 |
_promap.js | 100 | 100 | 100 | 100 |
_quote.js | 100 | 100 | 100 | 100 |
_reduce.js | 25 | 100 | 0 | 14.29 | 6-15
_reduced.js | 100 | 75 | 100 | 100 | 2
_stepCat.js | 88.24 | 80 | 100 | 88.24 | 34,45
_toISOString.js | 66.67 | 25 | 33.33 | 80 | 11
_toString.js | 100 | 100 | 100 | 100 |
_xArrayReduce.js | 100 | 100 | 100 | 100 |
_xReduce.js | 100 | 100 | 100 | 100 |
_xall.js | 100 | 100 | 100 | 100 |
_xany.js | 100 | 100 | 100 | 100 |
_xaperture.js | 100 | 100 | 100 | 100 |
_xchain.js | 100 | 100 | 100 | 100 |
_xdrop.js | 38.46 | 0 | 0 | 41.67 | 5-6,11-15,19
_xdropLast.js | 96 | 83.33 | 100 | 95.83 | 6
_xdropLastWhile.js | 100 | 100 | 100 | 100 |
_xdropRepeatsWith.js | 100 | 100 | 100 | 100 |
_xdropWhile.js | 100 | 100 | 100 | 100 |
_xfBase.js | 100 | 100 | 100 | 100 |
_xfilter.js | 100 | 100 | 100 | 100 |
_xfind.js | 94.12 | 75 | 100 | 93.75 | 13
_xfindIndex.js | 94.74 | 75 | 100 | 94.44 | 14
_xfindLast.js | 100 | 100 | 100 | 100 |
_xfindLastIndex.js | 100 | 100 | 100 | 100 |
_xmap.js | 100 | 100 | 100 | 100 |
_xpromap.js | 45.45 | 100 | 0 | 50 | 6-8,13,17
_xreduceBy.js | 91.67 | 66.67 | 100 | 91.67 | 20-21
_xscan.js | 100 | 100 | 100 | 100 |
_xtake.js | 100 | 100 | 100 | 100 |
_xtakeWhile.js | 100 | 100 | 100 | 100 |
_xtap.js | 100 | 100 | 100 | 100 |
_xuniqBy.js | 100 | 100 | 100 | 100 |
_xuniqWith.js | 100 | 100 | 100 | 100 |
_xwrap.js | 90 | 100 | 80 | 87.5 | 5
------------------------------|---------|----------|---------|---------|------------------- |
|
Whoops, apparently I did not search properly, all |
What is the reason behind that preference? |
Historically out of the box compatibility with es3. I believe the plan is to switch everything over to const/let after 1.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to refrain from using
constandletin favor ofvar, so I replaced some leftoverletin _clone.js