JSDoc: update head(), last(), and nth() to reflect actual behavior
#3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (863ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (935ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (909ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (904ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (935ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Harris-Miller
changed the title
last() and nth() to reflect actual behaviorhead(), last(), and nth() to reflect actual behavior
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (908ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (913ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
kedashoe
previously approved these changes
May 2, 2024
|
Can you remove the changes to |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (834ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
kedashoe
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while testing ramda/types#101 which effects the typings for
last()R.last(''); //=> ''is not true,R.last(''); //=> undefinedisLooking at the git-history of
head.js,last.jsandnth.js. This has always been the behavior, the documentation was incorrect from the get-go. I think it was a bad copy/paste assumption in thatinit()andtail()both return''when given''See in repl