Skip to content

Commit

Permalink
Lock 4.0.x to ~8.0.0 to indicate it does not support PHP 8.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@ramsey
ramsey committed Sep 24, 2021
1 parent ba8fff1 commit 833c5c9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Security


## 4.0.2 - 2021-09-24

### Fixed

* Lock 4.0.x to `~8.0.0` to indicate it does not support PHP 8.1.


## [4.0.1] - 2020-03-29

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"homepage": "https://github.com/ramsey/uuid",
"license": "MIT",
"require": {
"php": "^7.2 || ^8",
"php": "^7.2 || ~8.0.0",
"ext-json": "*",
"brick/math": "^0.8",
"ramsey/collection": "^1.0",
Expand Down

4 comments on commit 833c5c9

@GrahamCampbell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda too late to do this. Composer will just resolve 4.0.1 for people who use 4.0.* as a version constraint on PHP 8.1.

@ramsey
Copy link
Owner Author

@ramsey ramsey commented on 833c5c9 Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. ☹️

See also this discussion here: 3c1ce39#commitcomment-57044641

I'm not sure what approach to take. I can change it back to ^8, but since 4.0.x and 4.1.x will not work on PHP 8.1, what do I do? Do I need to make patch releases so they can work on PHP ^8, as advertised?

@GrahamCampbell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think doing nothing would have been fine. People can just treat it as a bug that is fixed in the latest 4.x release. That's how Symfony do things (they in fact have no upper bound on PHP versions).

@ramsey
Copy link
Owner Author

@ramsey ramsey commented on 833c5c9 Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I'll do new tags that switch back to ^8.

Please sign in to comment.