Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address mixing of period and start/end dates #1031

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Address mixing of period and start/end dates #1031

wants to merge 5 commits into from

Conversation

ValueRaider
Copy link
Collaborator

@ValueRaider ValueRaider commented Jul 13, 2022 •
edited

This is a proposed fix for #1030 - if period is set, and user also set start or end, then ignore start and end and print a message to user.

But maybe better fix is to use start/end to cap the received table. I honestly don't know. Discussion welcome

@ValueRaider ValueRaider changed the title Fix/period dates Address mixing of period and start/end dates Jul 13, 2022
@ValueRaider
Copy link
Collaborator Author

ValueRaider commented Nov 2, 2022 •
edited

Issue #1115 wants mixing of period and dates, so maybe alternative solution in #1030 better.

EDIT: I now disagree with #1030. Best to explicitly block mixing period with dates.

@ValueRaider ValueRaider mentioned this pull request Nov 13, 2022
Open
@ValueRaider ValueRaider marked this pull request as draft October 19, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ValueRaider