Disable recursive option in Linux #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
requested changes
Feb 16, 2023
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip
force-pushed
the
bugfix/3765-contexts
branch
from
37e6fc9
to
7d4a65f
Compare
mook-as
approved these changes
Feb 16, 2023
Do we have to revisit this now that we are on node 18? It is not clear to me if disabling the |
|
The documentation says:
So it sounds like it's still not there. That line isn't there for docs for NodeJS 20, so we can look again once we go there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue with Kubernetes contexts updating in the tray menu by disabling the recursive option in Linux.
I had originally attempted upgrading to Node.js 18 in #3958 but the issue still persisted. The recursive options should be supported in node 18, so we will have to circle back to understand why this approach failed.
closes #3765