Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where build output would contain invalid urls #5917

Merged
merged 1 commit into from May 11, 2022

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented May 11, 2022

  • When using ui-dashboard-index https://releases.rancher.com/dashboard/latest/index.html naving to 'Create' style pages resulted in page refresh
  • Caused by 404 on some files with urls containing //
  • Fix is to remove [name] in prod file names (see Invalid CSS asset filenames generated, breaks site operation nuxt/nuxt#8274)
    • This also flattens out the folder structure (avoids crazy paths like _nuxt/pages/account/create-key/pages/c/_cluster/_product/_resource/_id/pages/c/_cluster/_product/_resource)
    • image
    • vs
    • image

- Create actions when using `ui-dashboard-index` `https://releases.rancher.com/dashboard/latest/index.html` resulted in page refresh
- Caused by 404 on some filenames whiched contained '//'
- Fix is to remove `[name]` in prod file names
  - This also flattens out the folder structure (avoids crazy paths like `_nuxt/pages/account/create-key/pages/c/_cluster/_product/_resource/_id/pages/c/_cluster/_product/_resource`)
@richard-cox richard-cox added this to the v2.6.6 milestone May 11, 2022
@richard-cox richard-cox requested a review from nwmac May 11, 2022 09:45
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit 8ceaab6 into rancher:master May 11, 2022
@richard-cox richard-cox deleted the fix-build-output branch May 11, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants