Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of cypress to latest 10.x #9415

Merged
merged 3 commits into from Jul 25, 2023

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Jul 25, 2023

Occurred changes and/or fixed issues

Hopefully will resolve.

Cannot read properties of undefined (reading 'isServer')
TypeError: Cannot read properties of undefined (reading 'isServer')
    at TLSWrap.onerror (node:_tls_wrap:411:27)

There's more to this story, see cypress-io/cypress#22291 for additional information

Three checks for navigating to pages outside of the dashboard have been disabled - #9417

Hopefully will resolve
```
Cannot read properties of undefined (reading 'isServer')
TypeError: Cannot read properties of undefined (reading 'isServer')
    at TLSWrap.onerror (node:_tls_wrap:411:27)
```
@richard-cox richard-cox marked this pull request as ready for review July 25, 2023 14:25
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - do we have any plans to reintroduce these commented tests in the future or would it be best to remove them altogether?

@richard-cox
Copy link
Member Author

@rak-phillip The commented out tests will be addressed via #9417

@richard-cox richard-cox merged commit 660b3c7 into rancher:master Jul 25, 2023
10 checks passed
@richard-cox richard-cox deleted the bump-cypress branch July 25, 2023 14:49
@richard-cox richard-cox added this to the v2.7.next3 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants