Limit configmap cache&watch #2033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manno
force-pushed
the
cr-limit-configmap-cache
branch
2 times, most recently
from
0050a8f
to
42c7e7f
Compare
manno
force-pushed
the
cr-limit-configmap-cache
branch
2 times, most recently
from
a42f11a
to
768be38
Compare
manno
force-pushed
the
cr-limit-configmap-cache
branch
from
768be38
to
2db7fab
Compare
|
The upstream issue has been closed. However, using a simpler cache config seems to limit the cache, which can be proven with some benchmarking. |
manno
force-pushed
the
cr-limit-configmap-cache
branch
from
2db7fab
to
b7fdd83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2018
TODO
Getfor configmaps, too. Fails when gitrepo reconciler tries toCreateOrUpdatethetarget.yamlconfigmapDefaultNamespacesdoesn't seem to work for :"unable to list: test-7af124d because of unknown namespace for the cache"Opened: kubernetes-sigs/controller-runtime#2628