Integration tests #101
Merged
Integration tests #101
+399
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MbolotSuse
requested review from
bigkevmcd
and removed request for
bigkevmcd
MbolotSuse
force-pushed
the
integration-test
branch
from
de9cf90 to
e138690
Compare
MbolotSuse
force-pushed
the
integration-test
branch
from
e138690 to
cf3afe4
Compare
tomleb
reviewed
Sep 6, 2024
maxsokolovsky
suggested changes
Sep 6, 2024
MbolotSuse
force-pushed
the
integration-test
branch
from
cf3afe4 to
9557e46
Compare
tomleb
reviewed
Sep 6, 2024
MbolotSuse
force-pushed
the
integration-test
branch
from
9557e46 to
f7cbf0d
Compare
Adds integration tests using env-test to the sql pacakge. This only adds some tests for using the cache with filters.
Adds a functionality to install env test for CI. Also adjusts the make test functionality to check for setup-envtest.
maxsokolovsky
approved these changes
Sep 6, 2024
tomleb
approved these changes
Sep 9, 2024
moio
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Excellent work, thanks for taking the lead on this @MbolotSuse !
Very appreciated.
moio
added a commit
to moio/rancher
that referenced
this pull request
Oct 2, 2024
This includes various fixes to the UI Server-Side Pagination experimental feature: https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/enable-experimental-features/ui-server-side-pagination - rancher/lasso#86 - rancher/lasso#90 - rancher/lasso#85 - rancher/lasso#92 - rancher/lasso#79 - rancher/lasso#97 - rancher/lasso#94 - rancher/lasso#98 - rancher/lasso#108 - rancher/lasso#99 It also includes improvements to code collecting metrics: - rancher/lasso#89 - rancher/lasso#95 And to test code: - rancher/lasso#100 - rancher/lasso#101 Signed-off-by: Silvio Moioli <silvio@moioli.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rancher/rancher#45243. Adds some env-test based tests that attempt to use the SQL cache closer to how it's used in production. This only covers some basic filter cases, but sets up the framework to add tests for things like: transform functions, sorting, and pagination.
Note: This PR may need to be re-opened on a branch in the repo to allow the CI to run successfully.