Ensure all failed transactions are rolled back. #118
Merged
+148
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's only one remaining instance in lasso of a function that takes an instance of `db.TXClient`, finds an error situation that doesn't happen due to a database call (`Exec` or `ExecStmt`), and doesn't rollback the transaction before returning a non-nil error.
ericpromislow
requested review from
moio and
a team
and removed request for
a team
moio
approved these changes
Nov 13, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #46410
I only found one instance.
Basically any function that receives a transaction handle and returns a
non-nil error is responsible for ensuing the transaction is rolled back.
This is covered by any failed calls to
tx.Execortx.StmtExecbutin this case
ListOptionIndexer#afterUpsertcan fail on other situations,and is therefore responsible for rolling back the transaction.