Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sqlcache #123

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Remove sqlcache #123

merged 3 commits into from
Jan 23, 2025

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Jan 16, 2025

As lightly discussed, the vai cache is currently very steve specific and it's going to be faster to iterate if it's embedded directly into the steve repo.

This removes all mentions of the Vai cache.

Draft until we actually have the sqlcache added to steve.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@moio moio marked this pull request as ready for review January 21, 2025 09:43
@moio moio requested a review from a team as a code owner January 21, 2025 09:43
@moio moio requested a review from ericpromislow January 21, 2025 09:44
Copy link
Contributor

@moio moio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this and it's fine

@moio moio merged commit 9325fed into rancher:main Jan 23, 2025
1 check passed
@tomleb tomleb deleted the remove-sqlcache branch February 3, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants