[Forwardport] v2.6: Only update change #28
Merged
+59
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option causes the handle function to only proceed if the object was actually updated. This is intended to be used by applications with many objects and/or controllers types that have alternative means of rerunning when necessary. When the informer's resync their cache the update function is run. This reducing the overhead but has the tradeoff of not rerunning handlers that may rely on external objects or services or experience a bug causing them to not retry even if it was necessary. The result is that running the handler func on resync will mostly only serve the purpose of catching missed cache events.
cmurphy
approved these changes
May 18, 2022
|
Not familiar with the context - why is this going into master and not release/v2.6? |
|
@maxsokolovsky because there is no release/v2.6 in lasso. Master is effectively release/v2.6. |
maxsokolovsky
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#37350
Original PR:
#27