Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies for k8s 1.24 #31

Merged
merged 2 commits into from
Jun 27, 2022
Merged

update dependencies for k8s 1.24 #31

merged 2 commits into from
Jun 27, 2022
+219 −125

Conversation

kinarashah
Copy link
Member

@kinarashah kinarashah commented Jun 27, 2022 •
edited
Loading

@kinarashah kinarashah requested review from jiaqiluo, cmurphy, rmweir and a team June 27, 2022 20:28
jiaqiluo
jiaqiluo approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although CI fails because of missing FOSSA API key

@kinarashah
Copy link
Member Author

@jiaqiluo @rosskirkpat Apologies, had to add a new commit to ignore fossa failures per offline conversation with eio team.

@rosskirkpat
Copy link

Approved but I am not a member of @rancher/rancher2-committers so my approval is a pseudo-approval at best 😄

@kinarashah kinarashah merged commit 00d9c8e into rancher:master Jun 27, 2022
@kinarashah kinarashah deleted the k8s124 branch June 27, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmurphy cmurphy

@jiaqiluo jiaqiluo

@rosskirkpat rosskirkpat

@rmweir rmweir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kinarashah @rosskirkpat @cmurphy @jiaqiluo