don't rate limit key when registering handlers #5
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: EnqueueKey rate limits the key and is called by sharedcontroller's RegisterHandler. This is an issue because on startup we start enqueuing each key for each handler, causing the rate limit duration spike to hours very quickly. Solution: Adding the key to workqueue directly in EnqueueKey. This is what 2.4.x did as well, https://github.com/rancher/norman/blob/release/v2.4/controller/generic_controller.go#L187
dramich
approved these changes
Apr 8, 2021
nickgerace
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
EnqueueKey rate limits the key and is called by sharedcontroller's RegisterHandler.
This is an issue because on startup we start enqueuing each key for each handler, causing the rate limit duration spike to hours very quickly.
Solution:
Adding the key to workqueue directly in EnqueueKey. Also what we used to do it 2.4.x,
https://github.com/rancher/norman/blob/release/v2.4/controller/generic_controller.go#L187
rancher/rancher#31999