updated k8s-deps to 0.27.4 and controller runtime to 0.15.0 #51
+184
−500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
jiaqiluo
suggested changes
Aug 18, 2023
kinarashah
requested changes
Aug 18, 2023
There was a problem hiding this comment.
Since rancher will be updated to use capi v1.5.0, we'd also need to update corresponding controller-runtime version in lasso. https://github.com/kubernetes-sigs/cluster-api/blob/v1.5.0/go.mod#L46
#48 has partial update to v0.14.0 for reference
vardhaman22
force-pushed
the
k8s-127-lasso
branch
2 times, most recently
from
444757c to
ec98d91
Compare
vardhaman22
changed the title
also updated k8s deps to 0.27.4
vardhaman22
force-pushed
the
k8s-127-lasso
branch
from
ec98d91 to
f0a3b84
Compare
kinarashah
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: rancher/rancher#41840
for updating controller-runtime changes from #48 are added.