Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.28] Update k8s dependencies to 0.28.6 & controller runtime to 0.15.3 #56

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

chiukapoor
Copy link
Contributor

@chiukapoor chiukapoor commented Dec 21, 2023

Update

  • Add v1.28 support till January patches (0.28.6).
  • Bump controller runtime to 0.15.3

Related

Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
@chiukapoor chiukapoor force-pushed the rancher-v1.28 branch 2 times, most recently from 787bc85 to 4d814cd Compare January 19, 2024 06:48
@chiukapoor chiukapoor changed the title Update k8s dependencies to 0.28.5 & controller runtime to 0.15.3 Update k8s dependencies to 0.28.6 & controller runtime to 0.15.3 Jan 19, 2024
@chiukapoor chiukapoor changed the title Update k8s dependencies to 0.28.6 & controller runtime to 0.15.3 [v1.28] Update k8s dependencies to 0.28.6 & controller runtime to 0.15.3 Jan 22, 2024
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Copy link
Member

@kinarashah kinarashah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kinarashah kinarashah merged commit b969cc0 into rancher:master Jan 23, 2024
@tomleb
Copy link
Contributor

tomleb commented Feb 27, 2024

controller-runtime tag from https://github.com/kubernetes-sigs/cluster-api/blob/84b6eee92da051c9ea7ed0c4c0e6da9c56f8fa4f/go.mod#L46

Looking at this link, I see that controller-runtime 0.15.3 is used, but we also see the following:

	k8s.io/api v0.27.7
	k8s.io/apiextensions-apiserver v0.27.7
	k8s.io/apimachinery v0.27.7
	k8s.io/apiserver v0.27.7
	k8s.io/client-go v0.27.7
	k8s.io/cluster-bootstrap v0.27.2
	k8s.io/component-base v0.27.7

and looking at the changelog for controller runtime v0.15.3 I see that they added support for k8s 1.27, not 1.28.

It seems like support for 1.28 was added in controller-runtime v0.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants