Skip to content

Migrate Lasso to GHA #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2024
Merged

Migrate Lasso to GHA #68

merged 2 commits into from
May 29, 2024
+27 −27

Conversation

ericpromislow
Copy link
Contributor

@ericpromislow ericpromislow commented Apr 25, 2024 •
edited
Loading

This PR starts the process of rebuilding CI from drone to GHA.

This change:

  • moves all CI except fossa to GHA and drops .drone.yml

The fossa migration has to be done via a branch in the target repo for security reasons.

Related to: rancher/rancher#45227

Blockers:

Sorry, something went wrong.

@ericpromislow ericpromislow requested a review from a team as a code owner April 25, 2024 21:45
tomleb
tomleb reviewed Apr 26, 2024
View reviewed changes
@ericpromislow ericpromislow force-pushed the 45227-migrate-to-gha branch 3 times, most recently from 8d18941 to ada3325 Compare April 26, 2024 20:16
@ericpromislow ericpromislow requested a review from tomleb April 26, 2024 20:18
@ericpromislow ericpromislow force-pushed the 45227-migrate-to-gha branch 2 times, most recently from 1094bd5 to 6f26ca3 Compare April 30, 2024 18:58
tomleb
tomleb approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though maybe you have to rebase on top of master since there's a conflict with the .drone.yml file (even though you've removed it.. 😕 )

@ericpromislow ericpromislow force-pushed the 45227-migrate-to-gha branch 2 times, most recently from b776e44 to eede563 Compare May 16, 2024 18:58
@ericpromislow ericpromislow requested review from tomleb and a team May 16, 2024 19:05
tomleb
tomleb reviewed May 17, 2024
View reviewed changes
@ericpromislow ericpromislow force-pushed the 45227-migrate-to-gha branch from c823cf7 to 2f2603a Compare May 22, 2024 21:08
@ericpromislow
Migrate Lasso to GHA

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
1210eab
@ericpromislow ericpromislow force-pushed the 45227-migrate-to-gha branch from 2f2603a to 1210eab Compare May 22, 2024 21:12
@ericpromislow ericpromislow requested a review from tomleb May 22, 2024 21:13
tomleb
tomleb approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpromislow ericpromislow requested a review from a team May 28, 2024 17:39
nflynt
nflynt approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@nflynt nflynt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MbolotSuse MbolotSuse merged commit 37f557b into rancher:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleb tomleb

@nflynt nflynt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericpromislow @tomleb @nflynt @MbolotSuse