Add test that will break if UnsafeSet breaks #86
Merged
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Moioli <silvio@moioli.net>
10 tasks
bigkevmcd
reviewed
Jul 25, 2024
|
Good point, added, thanks @bigkevmcd |
bigkevmcd
approved these changes
Jul 25, 2024
MbolotSuse
approved these changes
Jul 25, 2024
krunalhinguu
pushed a commit
to krunalhinguu/lasso
that referenced
this pull request
Sep 18, 2024
SQLite based caching uses an Informer that unsafely sets the Indexer as the ability to set it is not present in client-go at the moment. Long term, we look forward contribute a patch to client-go to make that configurable. Until then, we are adding this canary test that will panic in case the indexer cannot be set. Signed-off-by: Silvio Moioli <silvio@moioli.net>
This was referenced Oct 1, 2024
moio
added a commit
to moio/rancher
that referenced
this pull request
Oct 2, 2024
This includes various fixes to the UI Server-Side Pagination experimental feature: https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/enable-experimental-features/ui-server-side-pagination - rancher/lasso#86 - rancher/lasso#90 - rancher/lasso#85 - rancher/lasso#92 - rancher/lasso#79 - rancher/lasso#97 - rancher/lasso#94 - rancher/lasso#98 - rancher/lasso#108 - rancher/lasso#99 It also includes improvements to code collecting metrics: - rancher/lasso#89 - rancher/lasso#95 And to test code: - rancher/lasso#100 - rancher/lasso#101 Signed-off-by: Silvio Moioli <silvio@moioli.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite based caching uses an
Informerthat unsafely sets theIndexeras the ability to set it is not present in client-go at the moment.Long term, we look forward contribute a patch to client-go to make that configurable.
Until then, we are adding this canary test that will panic in case the indexer cannot be set.