Expose metrics registration function #89
Merged
+34
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
log-metrics-init
branch
from
c63923a to
df1fd9d
Compare
Allows exposing metrics via a custom registerer, instead of forcing the use of prometheus.DefaultRegisterer. Also allows initializing metrics outside of init() which is generally considered an anti-pattern. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
log-metrics-init
branch
from
df1fd9d to
3fcc1e6
Compare
1 task
MbolotSuse
approved these changes
Jul 16, 2024
briandowns
approved these changes
Jul 16, 2024
moio
added a commit
to moio/rancher
that referenced
this pull request
Oct 2, 2024
This includes various fixes to the UI Server-Side Pagination experimental feature: https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/enable-experimental-features/ui-server-side-pagination - rancher/lasso#86 - rancher/lasso#90 - rancher/lasso#85 - rancher/lasso#92 - rancher/lasso#79 - rancher/lasso#97 - rancher/lasso#94 - rancher/lasso#98 - rancher/lasso#108 - rancher/lasso#99 It also includes improvements to code collecting metrics: - rancher/lasso#89 - rancher/lasso#95 And to test code: - rancher/lasso#100 - rancher/lasso#101 Signed-off-by: Silvio Moioli <silvio@moioli.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows exposing metrics via a custom registerer, instead of forcing the use of prometheus.DefaultRegisterer. Also allows initializing metrics outside of init() which is generally considered an anti-pattern.
The default behavior of calling
prometheus.DefaultRegisterer.MustRegister()is retained, ref:https://github.com/prometheus/client_golang/blob/fec6b222d9ac46f61b0194fd343d5a10bf1e1d09/prometheus/registry.go#L174-L178
I also had to add a function to avoid registering the kubernetes internal workqueue metrics, to prevent conflicts in k3s where kubernetes itself registers those in the same process:
lasso/pkg/metrics/workqueue.go
Lines 21 to 22 in 32d9687