feat(metrics): improve lasso_controller_total_cached_object #95
Conversation
aruiz14
force-pushed
the
improve-cache-metrics
branch
from
1aa983e to
e6d0525
Compare
|
It is my understanding that all current lasso metrics are gated behind the Should |
There was a problem hiding this comment.
I'd like to see tests added for this?
Might wanna checkout https://pkg.go.dev/github.com/prometheus/client_golang/prometheus/testutil
There was a problem hiding this comment.
LGTM. As @bigkevmcd remarked, it would be best to have some kind of testing around this.
| } | ||
|
|
||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| t.Cleanup(cancel) |
There was a problem hiding this comment.
You're calling cancel later in the code?
There was a problem hiding this comment.
Yes, cancelling the same context twice is harmless, and eliminates the chance of the first assertion failing, so that t.Fatal will make the cancel() unreachable.
Also, it kind of hurts my eyes not seeing defer cancel() after creating the context 😅 I used t.Cleanup though to express it's actual cleanup.
aruiz14
force-pushed
the
improve-cache-metrics
branch
from
1a5d2f9 to
b33ea5b
Compare
* Is updated frequently * Can be split by context, by calling `WithContextID` over the `context.Context` passed to `Start` * Deleted when cache is stopped
aruiz14
force-pushed
the
improve-cache-metrics
branch
from
b33ea5b to
1c9a1aa
Compare
|
@tomleb merging is restricted, could you please push the button whenever it suits you best? Thanks! |
This includes various fixes to the UI Server-Side Pagination experimental feature: https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/enable-experimental-features/ui-server-side-pagination - rancher/lasso#86 - rancher/lasso#90 - rancher/lasso#85 - rancher/lasso#92 - rancher/lasso#79 - rancher/lasso#97 - rancher/lasso#94 - rancher/lasso#98 - rancher/lasso#108 - rancher/lasso#99 It also includes improvements to code collecting metrics: - rancher/lasso#89 - rancher/lasso#95 And to test code: - rancher/lasso#100 - rancher/lasso#101 Signed-off-by: Silvio Moioli <silvio@moioli.net>
Issue: rancher/rancher#46783
Includes the following improvements:
WithContextIDover thecontext.Contextpassed toStart, see Improve lasso_controller_total_cached_object metrics rancher#46784Example:
(note for every
ctxwere set from rancher and can be changed)