New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Settings for RKE2/K3S Default Versions #37163
Merged
jiaqiluo
merged 1 commit into
rancher:release/v2.6
from
jiaqiluo:new-settings-for-default-verions
Apr 6, 2022
Merged
Add New Settings for RKE2/K3S Default Versions #37163
jiaqiluo
merged 1 commit into
rancher:release/v2.6
from
jiaqiluo:new-settings-for-default-verions
Apr 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paynejacob
suggested changes
Apr 4, 2022
jiaqiluo
force-pushed
the
new-settings-for-default-verions
branch
from
April 4, 2022 16:21
6a16810
to
56e849c
Compare
paynejacob
previously approved these changes
Apr 4, 2022
thedadams
previously approved these changes
Apr 4, 2022
jiaqiluo
force-pushed
the
new-settings-for-default-verions
branch
from
April 5, 2022 17:28
56e849c
to
d22c43a
Compare
Hi @thedadams @paynejacob , this PR is ready for your final review.
|
jiaqiluo
force-pushed
the
new-settings-for-default-verions
branch
2 times, most recently
from
April 5, 2022 17:44
177b862
to
1634ad8
Compare
…m as Settings, they are available under the "/v1/management.cattle.io.settings" endpoint automatically. Signed-off-by: Jiaqi Luo <6218999+jiaqiluo@users.noreply.github.com>
jiaqiluo
force-pushed
the
new-settings-for-default-verions
branch
from
April 5, 2022 17:45
1634ad8
to
a648ccd
Compare
paynejacob
approved these changes
Apr 6, 2022
paynejacob
approved these changes
Apr 6, 2022
paynejacob
approved these changes
Apr 6, 2022
thedadams
approved these changes
Apr 6, 2022
Oats87
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #36827
Problem
The default rke2/k3s version should be configurable per rancher version.
Both the default rke2/k3s version and rancher version need to be a range so we do not need to add a new entry each time when we release a new rancher version.
Solution
Rancher will get the version ranges from the channelserver, calculate the default versions for the current rancher version, and expose them as new
Settings
items:rke2-default-version
k3s-default-version
And they are available under the
/v1/management.cattle.io.settings
endpoint automatically.Dependency
We need to add the support for
appDefaults
to the channelsesrver : rancher/channelserver#17Testing
Note
To make the CI pass, this PR replaces the rancher/channelserver module with my fork. It will be switched back once the above PR to the channel server is merged.Update: the PR in rancher/channelsever was merged and we switched back to use the latest commit for it.