Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing 'ip link delete cilium_wg0' in rke2-killall.sh #5274

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

faelis
Copy link
Contributor

@faelis faelis commented Jan 15, 2024

Proposed Changes

The network interface 'cilium_wg0' (added when wireguard is enabled in cilium) is not removed by the rke2-killall.sh script.

Types of Changes

Bugfix

Verification

Testing

Linked Issues

5288

User-Facing Change


Further Comments

@faelis faelis requested a review from a team as a code owner January 15, 2024 10:32
Copy link
Contributor

@manuelbuil manuelbuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could you please:

  • Add the line in dist/bundle/bin/rke2-killall.sh too
  • Fill an issue in rke2 with "bug fix" type. Then link the issue to the PR (in the description, under Linked Issues)

Thanks!

@faelis
Copy link
Contributor Author

faelis commented Jan 16, 2024

Hi @manuelbuil ! thanks for the review. Just added the linked issue.
But I didn't find the dist/bundle/bin/rke2-killall.sh file in the rke2 project, not even the dist folder. Can you help me?

@manuelbuil
Copy link
Contributor

manuelbuil commented Jan 16, 2024

Hi @manuelbuil ! thanks for the review. Just added the linked issue. But I didn't find the dist/bundle/bin/rke2-killall.sh in the rke2 project, can you help me?

Sorry! Stupid me, that gets created when building rke2

@manuelbuil
Copy link
Contributor

manuelbuil commented Jan 16, 2024

I have a comment in the issue.

BTW, we are under code freeze right now for the January release. If you get two positive reviews, we will merge after code freeze and this PR will be part of the February release

@faelis
Copy link
Contributor Author

faelis commented Jan 16, 2024

I added the missing configuration in the issue.
The PR can wait the next release, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants