Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle files and sockets in extra mounts #5621

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Mar 15, 2024

Proposed Changes

Properly handle files and sockets in extra mounts

Also allows manually specifying HostPathType, in case an unhandled type is needed

Types of Changes

bugfix

Verification

See linked issue

  • Test that a socket can be mounted into a pod:
    /run/systemd/journal/dev-log:/dev/log
  • Test that an already existing file can be mounted into a pod:
    /usr/share/zoneinfo/Etc/UTC:/etc/localtime
    /usr/share/zoneinfo/Etc/UTC:/etc/localtime:ro
  • Test that a nonexistent file can be mounted into a pod, and will be created on first use:
    /tmp/example.txt:/tmp/example.txt:rw:FileOrCreate
    /tmp/example.txt:/tmp/example.txt:ro:FileOrCreate

Testing

Linked Issues

User-Facing Change


Further Comments

Also allows manually specifying HostPathType, in case an unhandled type is needed

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner March 15, 2024 16:12
@brandond brandond merged commit 8c8306d into rancher:master Mar 22, 2024
2 checks passed
@brandond brandond deleted the fix-extra-mount-file branch June 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants