Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt (temporary) PQC OID mappings from IETF hackathon #3589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented Jun 19, 2023

As suggested in #3585, this changes the (nonetheless temporary) OID mappings for Kyber, Dilithium and SPHINCS+ to the mappings used in the IETF interoperability hackathon.

For backward compatibility to Botan 3.0.0, we will be able to read the OIDs for Kyber/Dilithium that were previously defined in Botan's private region.

With SPHINCS+ merged earlier today no backward compatibility will be needed here. However, the hackathon does not seem to define OIDs for SPHINCS+ with SHAKE (let alone Haraka). We therefore have no other choice than to keep those in Botan's private region for now.

@janklaussner, @randombit Thoughts on that?

@reneme reneme added this to the Botan 3.1.0 milestone Jun 19, 2023
@coveralls
Copy link

Coverage Status

coverage: 91.711%. remained the same when pulling 3f1b143 on Rohde-Schwarz:chore/oid_assignments into 99dbdd5 on randombit:master.

@randombit
Copy link
Owner

@reneme Looks fine to me modulo the concerns about key encoding I raised in #3585. I have not had a chance to follow up on this aspect.

@randombit
Copy link
Owner

I'm going to defer on this one until 3.2 - the worst possible outcome here is we switch the OIDs but then the other implementations are using an incompatible key encoding. That would leave us with a bigger problem than the current situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants