Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Have a common base for Kyber/Dilithium structures #4024

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented Apr 19, 2024

... very much work in progress.

@coveralls
Copy link

coveralls commented Apr 22, 2024

Coverage Status

coverage: 92.002% (-0.02%) from 92.021%
when pulling 64f9db8 on Rohde-Schwarz:refactor/crystals_april
into b1a6d25 on randombit:master.

@reneme
Copy link
Collaborator Author

reneme commented Apr 23, 2024

clang's UBsan is complaining about a signed integer overflow in Kyber's montgomery reduction. Did we drop a reduce() somewhere?

/home/runner/work/botan/botan/build/build/include/internal/botan/internal/kyber_constants.h:50:42: runtime error: signed integer overflow: 3611157 * -3327 cannot be represented in type 'int'
  SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/runner/work/botan/botan/build/build/include/internal/botan/internal/kyber_constants.h:50:42 in 
  Ran for 354 seconds

@reneme
Copy link
Collaborator Author

reneme commented Apr 29, 2024

FYI: I won't continue working on this before end of May. ⏳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants