fix #2873 WM_NAME now shows "not accessible" in non-existent directories #2896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
RUNTIME ENVIRONMENT
CHECKLIST
CONTRIBUTING
document has been read [REQUIRED]HACKING
was not clear which tool to use specificallyDESCRIPTION
fixes #2873
Before ranger used to crash with
update_title=true
setting when trying to display a non-existent directory.The reason was a call to
UI.fm.thisdir.path
whileUI.fm.thisdir == None
when ranger is pointing to a non-existent directory, invalidating the path attribute.This PR checks if
UI.fm.thisdir
is None and makes sureWM_NAME
showsranger:not accessible
(same as the ranger UI).MOTIVATION AND CONTEXT
fix crashing issue detailed in #2873
TESTING
make test_py
has been run successfully. I was not sure which spellchecker to get,HACKING
wasn't super clear on this, sorry.Changes should not have any effects on the rest of the codebase.