Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordered conditions to fix %F macro substituting active object from previous tab #2914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drewjohnson2
Copy link

@drewjohnson2 drewjohnson2 commented Oct 28, 2023

ISSUE TYPE

  • Bug fix

RUNTIME ENVIRONMENT

  • Operating system and version: Manjaro 21.0.1
  • Terminal emulator and version: URxvt v9.22
  • Python version: 3.8.10
  • Ranger version/commit: 136416c
  • Locale: en_US.UTF-8

CHECKLIST

  • The CONTRIBUTING document has been read [REQUIRED]
  • All changes follow the code style [REQUIRED]
  • All new and existing tests pass [REQUIRED]
  • Changes require config files to be updated
    • Config files have been updated
  • Changes require documentation to be updated
    • Documentation has been updated
  • Changes require tests to be updated
    • Tests have been updated

DESCRIPTION

On the first run of the for loop on line 346 in actions.py the value found_current_tab is checked before any reassignment is possible. Flipping the order of the final two conditions in the loop remedies this issue.

MOTIVATION AND CONTEXT

#2866

TESTING

make test passes all tests
reproducing steps in bug gives desired effect

@drewjohnson2 drewjohnson2 changed the title Reordered conditions to fix %F macro substituting active object from … Reordered conditions to fix %F macro substituting active object from previous tab Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant