fix bulkrename: handle libcurses behavior change in patch level 20231111 #2935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
RUNTIME ENVIRONMENT
CHECKLIST
CONTRIBUTING
document has been read [REQUIRED]DESCRIPTION
Handle an error which breaks the bulk rename command due to changed curses behavior.
MOTIVATION AND CONTEXT
The libcurses patch level 20231111 introduces a change (described in this thread) which results in an unhandled error which aborts a
:bulkchange
operation.The following output is observed in the message log:
The above thread reports a similar issue, although in the case of ranger, removing curses.echo() and/or curses.endwin() results in incorrect ouput following file rename.
This PR addresses #2934
TESTING
curses.echo()
andcurses.endwin()
did not completely fix the behaviorui.suspend()
by:open_with
and:shell
commands which should utilize the terminal with no misbehavior1- needed to specify pylint <= 2.17.7