New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility issues with Python 2.6 #2942

Open

mingmingrr wants to merge 1 commit into ranger:master from mingmingrr:py26fix

Contributor

mingmingrr commented Jan 28, 2024

ISSUE TYPE

Bug fix

RUNTIME ENVIRONMENT

Operating system and version: NixOS 24
Terminal emulator and version: WezTerm 20230712-072601-f4abf8fd
Python version: 2.6.9
Ranger version/commit: 136416c
Locale: LC_ALL=C

CHECKLIST

The CONTRIBUTING document has been read [REQUIRED]
All changes follow the code style [REQUIRED]
All new and existing tests pass [REQUIRED]
Changes require config files to be updated
- Config files have been updated
Changes require documentation to be updated
- Documentation has been updated
Changes require tests to be updated
- Tests have been updated

DESCRIPTION, MOTIVATION AND CONTEXT

Various fixes for Python 2.6, namely:

multi with/as: with a as b, c as d: ...
list unpacking: [*a, *b, ...]
subprocess.check_output()
dictionary comprehension

TESTING

Ran make test_py with 3.11 and ran ranger with --clean on 2.6

IMAGES / VIDEOS

N/A


          exts: Fix Python 2.6 compatibility issues

4183a86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment