Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google-tag-manager): warn instead of throw err #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Itrulia
Copy link
Contributor

@Itrulia Itrulia commented Oct 8, 2020

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works.
  • I have added all necessary documentation (if appropriate)

What was done

Replaced throw new Error with a console.warn like the other packages have

@Itrulia Itrulia force-pushed the feat/google-tag-manager-warning-instead-of-error branch from 7b991b9 to 0a2a835 Compare October 8, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant