-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/typescript migration #862
Open
sroucheray
wants to merge
86
commits into
rapi-doc:master
Choose a base branch
from
PerfectMemory:feat/typescript-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/typescript migration #862
sroucheray
wants to merge
86
commits into
rapi-doc:master
from
PerfectMemory:feat/typescript-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Side note: my last commit is a fix for the response status not properly set when an error occurred. I encountered this error while working on a specific API. I took the opportunity to narrow down the type of the |
I merged master in my branch to keep up to date with latest commits |
fix: endpoint body handles properly internal links
…dify response (in case of using E2EE)" This reverts commit 18afdce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mrin9,
So here is the branch where I migrated the project to Typescript.
any
s where typing were difficult to understandThe remaining tasks I see
any
references in the code by proper types// TODO: Typescript migration...
in the code to find mistake in original code now catched by the Typescript compiler (usually it needs refactor or removal)One note about functions. You'll see that many functions have a first parameter named
this
, it's not a real parameter but the way typescript make it clear on which type of object the function is called (as many utility functions are called withcall
). https://www.typescriptlang.org/docs/handbook/2/functions.html#declaring-this-in-a-functionExample