Fix #966: Search click handler on spans #984
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with search where clicking on endpoint path/method is not scrolling due to event handler checking on event.target.contentId attribute
if (!navEl.dataset.contentId) {
return;
}
This fix makes sure when clicking on any child element to pass the proper data-content-id within the event.
Fix rapi-doc#966: Search click handler on spans
|
Hello @mrin9 Any updates on this one please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue (#966) with search where clicking on endpoint path/method is not scrolling due to event handler checking on event.target.contentId attribute. open to ideas/thoughts for a better fix
This fix makes sure when clicking on any child element to pass the proper data-content-id within the event , not only the wrapper div
element:
RapiDoc/src/templates/advance-search-template.js
Line 48 in 18afdce
Event handler condition
RapiDoc/src/rapidoc.js
Line 952 in 18afdce
Video:
RapiDoc.Search.mov