Add a stack to the statistics resource #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
madsbk
force-pushed
the
statistics_resource_counters_stack
branch
from
cb5cd34
to
5544fd7
Compare
madsbk
changed the title
madsbk
changed the title
madsbk
force-pushed
the
statistics_resource_counters_stack
branch
from
5544fd7
to
d6fd147
Compare
harrism
requested changes
May 22, 2024
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
…s_resource_counters_stack
…s_resource_counters_stack
bdice
reviewed
May 28, 2024
madsbk
added
breaking
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
wence-
requested changes
May 30, 2024
| current_mr = rmm.mr.get_current_device_resource() | ||
| yield | ||
| finally: | ||
| if current_mr is not rmm.mr.get_current_device_resource(): |
There was a problem hiding this comment.
Yes, the definition of equality between memory resources is that they are interchangeable for the purposes of allocate/deallocate pairs, which is not sufficient for the usage here.
…s_resource_counters_stack
harrism
reviewed
Jun 6, 2024
harrism
approved these changes
Jun 6, 2024
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to enable more fine-grained statistics, this PR adds a stack to
statistics_resource_adaptorCloses #1332
Checklist