perf(rect)!: Rect::inner takes Margin directly instead of reference

[EdJoPaTo]

BREAKING CHANGE: Margin needs to be passed without reference now.

-let area = area.inner(&Margin {
+let area = area.inner(Margin {
     vertical: 0,
     horizontal: 2,
 });

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.3%. Comparing base (257db62) to head (4b56775).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #1008   +/-   ##
=====================================
  Coverage   94.3%   94.3%           
=====================================
  Files         61      61           
  Lines      14767   14767           
=====================================
  Hits       13926   13926           
  Misses       841     841           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshka]

LGTM as a breaking change

• Update the PR message to be changelog focused (e.g. tell the user how they need to change their apps.) Something like "Rect::inner() now takes Margin instead of &Margin"
• Add the info to the breaking change doc
• Add the breaking change section of the commit (https://www.conventionalcommits.org/)
• Make sure there's a small example of how to fix the change in both places (this is overkill for such a small change, but doing it consistently makes it easy for users upgrading to search for this sort of thing easily)

Hold off merging until 0.27.0 release is ready to go after 0.26.2

[joshka]

Changes look good. We can merge this when we go to 0.27.0

I think the next version will probably be 0.26.2 and then have all breaking changes batched up in 0.27.0

[joshka]

BTW, I expect this will probably break a lot of projects (520 results):

https://github.com/search?q=ratatui+%22.inner%28%22+AND+%28NOT+org%3Aratatui-org%29+AND+%28NOT+is%3Afork%29&type=code

[kdheepak]

I'd like for this change to be made because it'll make it consistent with a future feature like: #931

[joshka]

I'd like for this change to be made because it'll make it consistent with a future feature like: #931

Sounds like we should break both things at the same time to avoid double breaks.