Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): switch to pnpm #304

Merged
merged 16 commits into from Jul 25, 2022
Merged

refactor(frontend): switch to pnpm #304

merged 16 commits into from Jul 25, 2022

Conversation

ravenclaw900
Copy link
Owner

No description provided.

@ravenclaw900
Copy link
Owner Author

ravenclaw900 commented Jul 13, 2022

Trying to switch to Yarn v3 (apparently it's v3 now) with Plug n' Play has admittedly given me a lot of trouble. Vite doesn't seem to be compatible with it: vitejs/vite#8357, and our strange workspace layout (with all frontend code located in the frontend directory doesn't seem to be really compatible either. The way I see it right now, we have 3 other options:

  1. Use Yarn v3 without PnP: This still has many of the problems with switching away from Yarn classic in the first place, for instance bad Dependabot support and breaking support with most tools that use (what used to be) package manager-agnostic solutions, and isn't that much of an improvement over Yarn classic.
  2. npm: Better tooling support and official, but still slower than Yarn v3 without PnP, and I've had problems with it in the past.
  3. pnpm: The solution that I'm leaning towards right now. Generally better support from everything, seems to solve some of the dependency issues that I've had in the past, and speed is in the middle of Yarn v3 (PnP) and npm. This would also allow us to go back to Dependabot, which I honestly prefer due to its better GitHub integration (Renovate still hasn't merged chore(deps): update dependency @sveltejs/vite-plugin-svelte to v1.0.1 #305).
    EDIT: Apparently pnpm also supports Plug n' Play (https://pnpm.io/feature-comparison), though it isn't required.

@ravenclaw900 ravenclaw900 changed the title refactor(frontend): switch to yarn v2 refactor(frontend): switch to pnpm Jul 24, 2022
@ravenclaw900 ravenclaw900 enabled auto-merge (squash) July 24, 2022 16:26
@ravenclaw900 ravenclaw900 merged commit e49ad59 into main Jul 25, 2022
@ravenclaw900 ravenclaw900 deleted the yarn-v2 branch July 25, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant