[serve] change application deploy_failed/unhealthy logs to error level #45211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if an application's status changes to `DEPLOY_FAILED` or `UNHEALTHY` we log the status message as `warning` level. We should log it as `error` level as that is more appropriate. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
edoakes
approved these changes
May 10, 2024
|
@edoakes ready for merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[serve] change application deploy_failed/unhealthy logs to error level
Currently if an application's status changes to
DEPLOY_FAILEDorUNHEALTHYwe log the status message aswarninglevel. We should log it aserrorlevel as that is more appropriate.Signed-off-by: Cindy Zhang cindyzyx9@gmail.com