feat(SideNav): Implementation, Documentation, Tests #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 436face The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
| * | ||
| * @default true | ||
| */ | ||
| isLazy?: boolean; |
There was a problem hiding this comment.
When would we need it to be false?
There was a problem hiding this comment.
In case they are doing document.querySelector somewhere, or if they want to render a portal container inside Drawer (portal container has to exist in DOM all time) which was the usecase for us in SideNav.
We have similar prop in Tabs so exposed it to consumers
chaitanyadeorukhkar
previously approved these changes
May 27, 2024
chaitanyadeorukhkar
approved these changes
May 28, 2024
anuraghazra
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has
Note
Don't be scared of seeing 6k+ changes. Its just documentation, snapshots, tests, etc
Changes
Additional Information
Component Checklist