Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blade): radio helptext being negative #2175

Merged
merged 8 commits into from
May 23, 2024
Merged

fix(blade): radio helptext being negative #2175

merged 8 commits into from
May 23, 2024

Conversation

anuraghazra
Copy link
Member

Description

fixes: #2132

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 14, 2024 •
edited

🦋 Changeset detected

Latest commit: 79450f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

✅ PR title follows Conventional Commits specification.

@anuraghazra anuraghazra mentioned this pull request May 14, 2024
Closed
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 14, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@rzpcibot
Copy link
Collaborator

rzpcibot commented May 14, 2024 •
edited

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
⬇ ActionList, ActionListItem, ActionListItemBadge, ActionListItemBadgeGroup, ActionListItemIcon, ActionListItemText, ActionListSection 12.763 12.757 -0.006 KB
⬇ Checkbox 5.978 5.971 -0.007 KB
⬇ Radio 4.776 4.768 -0.008 KB
⬇ Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions 57.337 57.334 -0.003 KB
⬇ Tooltip, TooltipInteractiveWrapper 15.428 15.427 -0.001 KB
⬇ PhoneNumberInput 53.891 53.885 -0.006 KB

Generated by 🚫 dangerJS against 79450f7

snitin315
snitin315 reviewed May 15, 2024
View reviewed changes
packages/blade/src/components/Radio/Radio.tsx
const showHelpText = !hasError && helpText;
const showHelpText = helpText;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have similar logic in other components too. Do we need to update all of them?

https://github.com/search?q=repo%3Arazorpay%2Fblade%20showHelpText&type=code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed on Checkbox/Radio.

FileUpload I'm not sure because it doesn't have nested items like Radio/RadioGroup.

Chips me we might need. We can check.

@anuraghazra anuraghazra merged commit 00c87e8 into master May 23, 2024
13 checks passed
@anuraghazra anuraghazra deleted the anu/radio-helptext-color branch May 23, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

@chaitanyadeorukhkar chaitanyadeorukhkar Awaiting requested review from chaitanyadeorukhkar chaitanyadeorukhkar is a code owner

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani kamleshchandnani is a code owner

@saurabhdaware saurabhdaware Awaiting requested review from saurabhdaware saurabhdaware is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helpText in Radio component has red color
3 participants
@anuraghazra @rzpcibot @snitin315