Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documents #248

Merged
merged 5 commits into from
May 27, 2024
Merged

added documents #248

merged 5 commits into from
May 27, 2024

Conversation

ankitdas13
Copy link
Contributor

@ankitdas13 ankitdas13 commented Apr 29, 2024

@ankitdas13 ankitdas13 requested a review from bhavyay May 2, 2024 06:20

**Parameters:**

| Name | Type | Description |
Copy link
Contributor

@bhavyay bhavyay May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format the table

| Name | Type | Description |

documents/documents.md Show resolved Hide resolved
stub_get(%r{documents/#{@document_id}$}, 'fake_document')
end

def test_document_should_be_defined
Copy link
Contributor

@bhavyay bhavyay May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test cases for checking the response in case of success and failure cases.

def test_document_should_be_defined_exception

@ankitdas13 ankitdas13 requested a review from bhavyay May 24, 2024 11:33
@ankitdas13 ankitdas13 added the TestingNotRequired TestingNotRequired label for BVT label May 27, 2024
@ankitdas13 ankitdas13 merged commit d7f0aeb into master May 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants