added reversals #250
Merged
added reversals #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavyay
reviewed
May 22, 2024
| @@ -73,5 +73,12 @@ def test_transfer_direct_transfer | |||
| assert_equal transfer.id, @transfer_id , 'Transfer transfer_id is accessible' | |||
| refute transfer.on_hold | |||
| end | |||
|
|
|||
| def test_fetch_reversals | |||
| stub_get(%r{/transfers/#{@transfer_id}/reversals$}, 'reversals_collection') | |||
There was a problem hiding this comment.
please add test case for 5xx response.
There was a problem hiding this comment.
Added test cases
bhavyay
reviewed
May 27, 2024
documents/transfers.md
Outdated
| ### Fetch Reversals for a Transfer | ||
| ```rb | ||
| transferId = "trf_JhemwjNekar9Za" | ||
| Razorpay::Transfer.fetch(transferId).reversals |
There was a problem hiding this comment.
please remove the method chaining
There was a problem hiding this comment.
Removed chaining , also updated in doc and unit test
razorpay-ruby/lib/razorpay/transfer.rb
Line 35 in 3eaf6ba
bhavyay
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc reference
Fetch Reversals for a Transfer