Using <a> to support nested text-decoration
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also uses `const` in README and fixes typo in sp. (of "usage") in CLI help
…k>` (`<blink>` assumes a CSS keyframes at-rule that cannot be defined inline, e.g.,: `@keyframes blink {50% {opacity: 0;}}`)
- Fix: Switch from `<span>` to `<a>` (without `href`); allows `text-decoration` to be overridden (without changing to a format-breaking `inline-block`); (div set to inline also does not work as `text-decoration` is a special case); the newly renamed tests, "disables underline" and "rendering un-italic code appropriately", might not work as you wish, as they include an unnecessary disabling of underlining/italic tag, though perhaps if someone added that ANSI code, they actually wanted it (e.g., if assembling ansi together)
- Enhancement: Add rapid blink as distinct from slow blink
…ne (default) or bold-off - Enhancement: Add alternativeFonts option - Enhancement: Add fainter (2), Primary(default) font (10), 11-19 (alternative fonts), double-underline or bold-off (21), Blink off (25), Reveal (28), Not crossed out (29), Not overlined (55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #57 .
I have switched here to using
<a>instead of<span>.The reason is that span will not allow overriding
text-decorationstyles (I had some underlining which wasn't getting disabled for this reason). (The same problem occurs in ansi-to-html's current state.)I would have thought divs would work, but when using
<div style="display: inline;">, though the Inspector (in Firefox or Chrome) shows the nested values as applying (e.g., atext-decoration: none), it still shows the content with an underline. This issue appears specific totext-decoration; the following can offer some more detail: https://stackoverflow.com/questions/1823341/how-do-i-get-this-css-text-decoration-override-to-workBut things work fine in both Firefox and Chrome when I change the elements to an
<a>instead (withouthref). One problem is that the browser source shows this as invalid, I guess for having both flow and phrasing content, but I still think this may be the best solution.You expressed concerns about this in #57 , but I think this is the only way to truly work with
text-decorationoverrides (as needed when overriding underline, strike-through, and overline). If you want this behind a flag, let me know.(While I may be able to go back to using spans for the colors, I'm not sure if there are any cases where resetting a color should also reset the text-decoration. And I haven't added any tests for resetting command 0 to see its effect with text-decoration.)