Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/gitannex: Add layout modes for compatibility #7754

Merged
merged 11 commits into from
May 13, 2024
Merged

cmd/gitannex: Add layout modes for compatibility #7754

merged 11 commits into from
May 13, 2024

Commits on May 13, 2024

  1. cmd/gitannex: Simplify messageParser's finalParameter() func 

    Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b3590d2 View commit details
    Browse the repository at this point in the history

  2. cmd/gitannex: Add support for different layouts 

    This commit adds support for the same repo layouts supported by
git-annex-remote-rclone. This should enable git-annex users with remotes
of type "rclone" to switch to a "rclone-builtin" without needing to
retransfer content.

Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c2d46e4 View commit details
    Browse the repository at this point in the history

  3. cmd/gitannex: Refactor e2e tests, add layout compat tests 

    TestEndToEndRepoLayoutCompat exercises git-annex-remote-rclone-builtin
and git-annex-remote-rclone on the same rclone remote to ensure they are
compatible. It repeats the same test for all known layout modes.

Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ed72e48 View commit details
    Browse the repository at this point in the history

  4. cmd/gitannex: Repeat TestEndToEnd for all layout modes 

    I'm hopeful that running these in parallel will not impact CI runtime
very much, but that likely depends on the number of CPU cores and
whether the tmp filesystem is backed by memory vs a physical disk.

Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    8734d75 View commit details
    Browse the repository at this point in the history

  5. cmd/gitannex: Drop chdir from e2e tests 

    Now that e2e tests are running in parallel, undoing the chdir to the
temp dir was causing flaky failures on cleanup. We don't need it anyway
because the worrisome subcommands have their working directory
controlled by `runInRepo()`.

Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b60f99e View commit details
    Browse the repository at this point in the history

  6. cmd/gitannex: Describe new rclonelayout config in help 

    Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ba40332 View commit details
    Browse the repository at this point in the history

  7. cmd/gitannex: Add TestEndToEndMigration tests 

    For each layout mode, these tests start with a git-annex-remote-rclone
remote, migrate it to a git-annex-remote-rclone-builtin remote. They
verify that a file copied pre-migration is still present and that `git
annex testremote` passes.

Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3bb5fec View commit details
    Browse the repository at this point in the history

  8. .github/workflows: Install git-annex-remote-rclone on Linux and macOS 

    Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    019f91b View commit details
    Browse the repository at this point in the history

  9. cmd/gitannex: Remove assumption in e2e test version check

    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1cbf9a2 View commit details
    Browse the repository at this point in the history

  10. build: Inject rclone version tag when testing 

    This enables gitannex end-to-end tests to run on CI. Otherwise, the
version would not match and tests that check the rclone version would
fail like so:

```
=== RUN   TestEndToEnd
    e2e_test.go:199: Skipping due to rclone version: expected version "v1.67.0-DEV", but got "v1.67.0-beta.7905.220bbe24d.merge"
--- SKIP: TestEndToEnd (0.07s)
```

Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6370301 View commit details
    Browse the repository at this point in the history

  11. cmd/gitannex: When tags do not match, run e2e tests anyway 

    Issue rclone#7625
    @dmcardle
    dmcardle committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d2196bf View commit details
    Browse the repository at this point in the history