New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issues related to encoding #7791
base: master
Are you sure you want to change the base?
Conversation
1863b81
to
9d74a49
Compare
I think I'd prefer |
Backward compatibility. |
@ncw any progress or further concern? :-) |
fixed #7824
|
Fix the way to disable encoding by introducing a new type
Raw
to solve #7456 and #6098.See #7456 and the changes on the document for details.
The behavior of
None
was not changed to keep backward compatibility.And fix vfs cache encoding described in #7760
The problem is when we create and write cache, we use the "OS" encoded ("OS" encoding is hardcoded for different operating systems, not specified by users).
But when we copy it to the remote (backend), we use local.Fs, which accept a name already encoded in "Standard" way.
So we need to send a "Standard" encoded name.
However, the "minimum setup" mentioned in #7760 has not been resolved. See my comment in it for details.
But it's an edge case.
Checklist